Attention is currently required from: fixeria, pespin.

View Change

4 comments:

• File src/osmo-bsc/nm_bb_transc_fsm.c:

  • Patch Set #1, Line 345: case NM_EV_RAMP_GO:

    I'm not really following you. […]

    In the past yes, I've changed the code so it couldn't happen again. but i'm not sure if it's better this way.

• File src/osmo-bsc/nm_bts_fsm.c:

  • Patch Set #1, Line 92: struct gsm_bts *bts,

    Actually, I see now that you are changing the formatting of this line for now reason, so leave it wa […]

    Done

• File src/osmo-bsc/nm_bts_fsm.c:

  • Patch Set #4, Line 401: .ignore_invalid_events =

    As mentioned I don't think this is needed. We can discuss it further.

    i've replaced it.

• File src/osmo-bsc/nm_channel_fsm.c:

  • Patch Set #10, Line 224: configure_loop(ts, &ts->mo.nm_state, false);

    this is wrong, it should be "true".

    Done

To view, visit change 29788. To unsubscribe, or for help writing mail filters, visit settings.