Change in osmo-trx[master]: ms-trx support

Attention is currently required from: laforge, pespin, fixeria. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 ) Change subject: ms-trx support ...................................................................... Patch Set 13: (9 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1c93ce73_fc68b288 PS10, Line 15: C Done File Transceiver52M/Makefile.am: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/92ab80ee_46e9c7e5 PS3, Line 115: $(TRXCON_LDADD) Done File Transceiver52M/Makefile.am: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/952e7977_153895b0 PS11, Line 179: osmo_trx_syncthing_blade_CPPFLAGS = $(AM_CPPFLAGS) $(BLADE_CFLAGS) -DSYNCTHINGONLY -DBUILDBLADE -I../device/ipc abosolutely does not matter here, the directory layout has been unchanged for 10 years and this directory is still called transceiver52m even though that refers to usrp1 days and issues, no reason to expect dynamically changing dir layouts, ever. File Transceiver52M/ms/itrq.h: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a67390c4_89e8ee9d PS11, Line 127: class spsc : public T<block_read, block_write> { a clumsy bad c copy of this, yes. File Transceiver52M/ms/logging.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2b3b7da2_8fe9b53d PS11, Line 83: void trxc_log_init(void *tallctx) Done File Transceiver52M/ms/ms.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a5b6bc2f_3c64343f PS11, Line 312: // in thory fn equal and tn+3 equal is also a problem... Done File Transceiver52M/ms/ms_upper.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/66a6017f_27acb1b9 PS11, Line 297: case trxcon::TRXCON_PHYIF_CMDT_RESET: Done File Transceiver52M/ms/sch.h: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2c086632_77c67f34 PS11, Line 7: * (C) 2022 by 2022 by sysmocom s.f.m.c. GmbH &lt;info(a)sysmocom.de&gt; / Eric Wild &lt;ewild(a)sysmocom.de&gt; Done File Transceiver52M/ms/sch.c: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b49d8864_26d0b63c PS11, Line 97: int gsm_fcch_check_fn(int fn) the whole file is copy&paste of various private libosmocore parts, originally created by tom tsou in his ms branch 10 years ago, which is also where this transceiver started, and then I kept adding to it. That being said I had a look at libosmocore, but stuff I need is either internal, or does not exist, i.e. sch reduced fn to gsm time and so on. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 Gerrit-Change-Number: 30416 Gerrit-PatchSet: 13 Gerrit-Owner: Hoernchen &lt;ewild(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-CC: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Comment-Date: Mon, 05 Dec 2022 17:03:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge &lt;laforge(a)osmocom.org&gt; Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-MessageType: comment