[M] Change in osmocom-bb[master]: trx_toolkit/*: Try to avoid copying burst data where possible

Attention is currently required from: kirr. pespin has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39537?usp=email ) Change subject: trx_toolkit/*: Try to avoid copying burst data where possible ...................................................................... Patch Set 2: (1 comment) File src/target/trx_toolkit/data_msg.py: https://gerrit.osmocom.org/c/osmocom-bb/+/39537/comment/c9b0f578_e15f2838?u… : PS2, Line 336: burst = memoryview(burst)[:EDGE_BURST_LEN] I never used memoryview nor read about the details, but in line "burst = memoryview(burst)[:EDGE_BURST_LEN]" I'd expect 2 steps: 1- "memoryview(burst)" Generate a memory view of burst 2- "[:EDGE_BURST_LEN]" Generate a slice (potentialy a copy?) of the burst memory view you just created So as mentioned, I have no real knowledge, just mentioning in case "memoryview(memoryview(burst)[:EDGE_BURST_LEN])" makes sense. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39537?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I147da2f110dedc863361059c931f609c28a69e9c Gerrit-Change-Number: 39537 Gerrit-PatchSet: 2 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Comment-Date: Thu, 13 Feb 2025 19:50:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: kirr <kirr(a)nexedi.com> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>