Attention is currently required from: kirr.
pespin has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39537?usp=email )
Change subject: trx_toolkit/*: Try to avoid copying burst data where possible ......................................................................
Patch Set 2:
(1 comment)
File src/target/trx_toolkit/data_msg.py:
https://gerrit.osmocom.org/c/osmocom-bb/+/39537/comment/c9b0f578_e15f2838?us... : PS2, Line 336: burst = memoryview(burst)[:EDGE_BURST_LEN]
Could you please clarify? Do you mean here that we create a copy via `self. […]
I never used memoryview nor read about the details, but in line "burst = memoryview(burst)[:EDGE_BURST_LEN]" I'd expect 2 steps: 1- "memoryview(burst)" Generate a memory view of burst 2- "[:EDGE_BURST_LEN]" Generate a slice (potentialy a copy?) of the burst memory view you just created
So as mentioned, I have no real knowledge, just mentioning in case "memoryview(memoryview(burst)[:EDGE_BURST_LEN])" makes sense.