Attention is currently required from: kirr.

View Change

1 comment:

• File src/target/trx_toolkit/data_msg.py:

  • Patch Set #2, Line 336: burst = memoryview(burst)[:EDGE_BURST_LEN]

    Could you please clarify? Do you mean here that we create a copy via `self. […]

    I never used memoryview nor read about the details, but in line "burst = memoryview(burst)[:EDGE_BURST_LEN]" I'd expect 2 steps:
    1- "memoryview(burst)" Generate a memory view of burst
    2- "[:EDGE_BURST_LEN]" Generate a slice (potentialy a copy?) of the burst memory view you just created

    So as mentioned, I have no real knowledge, just mentioning in case "memoryview(memoryview(burst)[:EDGE_BURST_LEN])" makes sense.

To view, visit change 39537. To unsubscribe, or for help writing mail filters, visit settings.