27 Apr
2023
27 Apr
'23
2:31 p.m.
Attention is currently required from: msuraev.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/simtrace2/+/32487 )
Change subject: Cosmetic: fix CI errors
......................................................................
Patch Set 2:
(1 comment)
File .checkpatch.conf:
https://gerrit.osmocom.org/c/simtrace2/+/32487/comment/b04a7838_1e1549c4
PS2, Line 1: --exclude ^firmware/atmel_softpack_libraries/.*$
Why do we need to exclude this? Does it cause some
particular error?
yes, due to the other changes in this patch:
```
firmware/atmel_softpack_libraries/libchip_sam3s/chip.h:18: WARNING:SPACING: space
prohibited between function name and open parenthesis '('
firmware/atmel_softpack_libraries/libchip_sam3s/chip.h:18: ERROR:SPACING: space prohibited
after that open parenthesis '('
firmware/atmel_softpack_libraries/libchip_sam3s/chip.h:18: ERROR:SPACING: space prohibited
before that close parenthesis ')'
firmware/atmel_softpack_libraries/usb/include/USBD.h:66: WARNING:SPACING: space prohibited
between function name and open parenthesis '('
firmware/atmel_softpack_libraries/usb/include/USBD.h:66: ERROR:SPACING: space prohibited
after that open parenthesis '('
firmware/atmel_softpack_libraries/usb/include/USBD.h:66: ERROR:SPACING: space prohibited
before that close parenthesis ')'
firmware/atmel_softpack_libraries/usb/include/USBDescriptors.h:299: WARNING:SPACING: space
prohibited between function name and open parenthesis '('
firmware/atmel_softpack_libraries/usb/include/USBDescriptors.h:299: ERROR:SPACING: space
prohibited after that open parenthesis '('
firmware/atmel_softpack_libraries/usb/include/USBDescriptors.h:299: ERROR:SPACING: space
prohibited before that close parenthesis ')'
```
as this is some code imported from 3rd party, it doesn't follow our code guidelines
and it's not useful to change it to do that here
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/32487
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: Ibb2e42e9b4307275a33e4000c201847a6bd60137
Gerrit-Change-Number: 32487
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 27 Apr 2023 12:31:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment