Attention is currently required from: msuraev.
1 comment:
File .checkpatch.conf:
Patch Set #2, Line 1: --exclude ^firmware/atmel_softpack_libraries/.*$
Why do we need to exclude this? Does it cause some particular error?
yes, due to the other changes in this patch:
```
firmware/atmel_softpack_libraries/libchip_sam3s/chip.h:18: WARNING:SPACING: space prohibited between function name and open parenthesis '('
firmware/atmel_softpack_libraries/libchip_sam3s/chip.h:18: ERROR:SPACING: space prohibited after that open parenthesis '('
firmware/atmel_softpack_libraries/libchip_sam3s/chip.h:18: ERROR:SPACING: space prohibited before that close parenthesis ')'
firmware/atmel_softpack_libraries/usb/include/USBD.h:66: WARNING:SPACING: space prohibited between function name and open parenthesis '('
firmware/atmel_softpack_libraries/usb/include/USBD.h:66: ERROR:SPACING: space prohibited after that open parenthesis '('
firmware/atmel_softpack_libraries/usb/include/USBD.h:66: ERROR:SPACING: space prohibited before that close parenthesis ')'
firmware/atmel_softpack_libraries/usb/include/USBDescriptors.h:299: WARNING:SPACING: space prohibited between function name and open parenthesis '('
firmware/atmel_softpack_libraries/usb/include/USBDescriptors.h:299: ERROR:SPACING: space prohibited after that open parenthesis '('
firmware/atmel_softpack_libraries/usb/include/USBDescriptors.h:299: ERROR:SPACING: space prohibited before that close parenthesis ')'
```
as this is some code imported from 3rd party, it doesn't follow our code guidelines and it's not useful to change it to do that here
To view, visit change 32487. To unsubscribe, or for help writing mail filters, visit settings.