[M] Change in ...osmo-s1gw[master]: erab_fsm: implement E-RAB MODIFY Req/Rsp procedure

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39116?usp=email ) Change subject: erab_fsm: implement E-RAB MODIFY Req/Rsp procedure ...................................................................... Patch Set 3: Code-Review+1 (2 comments) File src/erab_fsm.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39116/comment/78090285_9942… : PS3, Line 78: -type mod_kind() :: setup_rsp | would be far easier to figure out all these values in code if they were prefixed with "mod_kind_" https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39116/comment/9f3e13c4_b4db… : PS3, Line 323: ok probably easier to match upon return if you return {ok, undefined}? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39116?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I24d57ea390d71b640cb42046a8658e9d30670682 Gerrit-Change-Number: 39116 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Dec 2024 11:47:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes