Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39116?usp=email )
Change subject: erab_fsm: implement E-RAB MODIFY Req/Rsp procedure ......................................................................
Patch Set 3: Code-Review+1
(2 comments)
File src/erab_fsm.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39116/comment/78090285_9942d... : PS3, Line 78: -type mod_kind() :: setup_rsp | would be far easier to figure out all these values in code if they were prefixed with "mod_kind_"
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39116/comment/9f3e13c4_b4db4... : PS3, Line 323: ok probably easier to match upon return if you return {ok, undefined}?