Attention is currently required from: fixeria.
Patch set 3:Code-Review +1
View Change
2 comments:
File src/erab_fsm.erl:
Patch Set #3, Line 78: -type mod_kind() :: setup_rsp |
would be far easier to figure out all these values in code if they were prefixed with "mod_kind_"
Patch Set #3, Line 323: ok
probably easier to match upon return if you return {ok, undefined}?
To view, visit change 39116. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I24d57ea390d71b640cb42046a8658e9d30670682
Gerrit-Change-Number: 39116
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Thu, 12 Dec 2024 11:47:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes