tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26837 )
Change subject: icE1usb fw: Use 'int' as the default type for port index ......................................................................
Patch Set 1:
Patch Set 1:
I would argue it should always be an unsigned integer everywhere unless there can ever be a negative port number (which I gues there cannot).
Actually in the helper converting usb request to the corresponding port number, -1 is used as return code in case the request is for a non existent port. ( Because for those conversion a USB error needs to be returned rather than a panic() )