Patch Set 1:

I would argue it should always be an unsigned integer everywhere unless there can ever be a negative port number (which I gues there cannot).

Actually in the helper converting usb request to the corresponding port number, -1 is used as return code in case the request is for a non existent port. ( Because for those conversion a USB error needs to be returned rather than a panic() )

View Change

To view, visit change 26837. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: I50a76476af844acf20436b9d410cb917b723590d
Gerrit-Change-Number: 26837
Gerrit-PatchSet: 1
Gerrit-Owner: tnt <tnt@246tNt.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Comment-Date: Mon, 10 Jan 2022 14:16:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment