laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/29634 )
Change subject: usb: Fix ICE1USB_INTF_SET_GPSDO_MODE request parameter ......................................................................
usb: Fix ICE1USB_INTF_SET_GPSDO_MODE request parameter
This call takes its argument in wValue rather than as payload
Signed-off-by: Sylvain Munaut tnt@246tNt.com Change-Id: Ibeebe3184a4744bd0cd9f5a19db84c12fab18806 --- M src/usb.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve
diff --git a/src/usb.c b/src/usb.c index 97e2563..b511adb 100644 --- a/src/usb.c +++ b/src/usb.c @@ -635,8 +635,8 @@ { const uint16_t bmReqType = LIBUSB_RECIPIENT_INTERFACE | LIBUSB_REQUEST_TYPE_VENDOR | LIBUSB_ENDPOINT_OUT; - return _e1_usb_intf_send_ctrl(intf, bmReqType, ICE1USB_INTF_SET_GPSDO_MODE, 0, - (uint8_t *)&gpsdo_mode, sizeof(gpsdo_mode)); + return _e1_usb_intf_send_ctrl(intf, bmReqType, ICE1USB_INTF_SET_GPSDO_MODE, gpsdo_mode, + NULL, 0); }
int
1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.