laforge submitted this change.

View Change

Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve
usb: Fix ICE1USB_INTF_SET_GPSDO_MODE request parameter

This call takes its argument in wValue rather than as payload

Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
Change-Id: Ibeebe3184a4744bd0cd9f5a19db84c12fab18806
---
M src/usb.c
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/usb.c b/src/usb.c
index 97e2563..b511adb 100644
--- a/src/usb.c
+++ b/src/usb.c
@@ -635,8 +635,8 @@
{
const uint16_t bmReqType = LIBUSB_RECIPIENT_INTERFACE | LIBUSB_REQUEST_TYPE_VENDOR |
LIBUSB_ENDPOINT_OUT;
- return _e1_usb_intf_send_ctrl(intf, bmReqType, ICE1USB_INTF_SET_GPSDO_MODE, 0,
- (uint8_t *)&gpsdo_mode, sizeof(gpsdo_mode));
+ return _e1_usb_intf_send_ctrl(intf, bmReqType, ICE1USB_INTF_SET_GPSDO_MODE, gpsdo_mode,
+ NULL, 0);
}

int

1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.

To view, visit change 29634. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Ibeebe3184a4744bd0cd9f5a19db84c12fab18806
Gerrit-Change-Number: 29634
Gerrit-PatchSet: 4
Gerrit-Owner: tnt <tnt@246tNt.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-MessageType: merged