Attention is currently required from: msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31299 )
Change subject: socket: propagate error in osmo_sock_unix_init() to the caller ......................................................................
Patch Set 2: Code-Review-1
(3 comments)
File src/core/socket.c:
https://gerrit.osmocom.org/c/libosmocore/+/31299/comment/ee38ed76_7172f2d3 PS1, Line 1422: return -1; Removing this looks unrelated. Why not just 'return rc'?
https://gerrit.osmocom.org/c/libosmocore/+/31299/comment/c15e7bca_7c589734 PS1, Line 1396: sfd This is not really a change: according to the manpage, in case of an error "a value of -1 shall be returned and errno set to indicate the error." So it was -1, and will be -1 after your change. You should return -errno instead.
https://gerrit.osmocom.org/c/libosmocore/+/31299/comment/589b4147_5d49176a PS1, Line 1420: sfd = rc; If you keep the 'err' label, you can just do 'goto' here.