Attention is currently required from: msuraev.

Patch set 2:Code-Review -1

View Change

3 comments:

• File src/core/socket.c:

  • Patch Set #1, Line 1422: return -1;

    Removing this looks unrelated. Why not just 'return rc'?

  • Patch Set #1, Line 1396: sfd

    This is not really a change: according to the manpage, in case of an error "a value of -1 shall be returned and errno set to indicate the error." So it was -1, and will be -1 after your change. You should return -errno instead.

  • Patch Set #1, Line 1420: sfd = rc;

    If you keep the 'err' label, you can just do 'goto' here.

To view, visit change 31299. To unsubscribe, or for help writing mail filters, visit settings.