Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28327 )
Change subject: lchan_select: allow different alloc order for assignment and handover ......................................................................
Patch Set 2:
(2 comments)
File src/osmo-bsc/bts_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/28327/comment/a8d78562_ddf0d96f PS1, Line 541: DEFUN_ATTR(cfg_bts_challoc_mode_all,
iiuc this should be marked as DEPRECATED in favor of "mode set-all"
It was already marked as CMD_ATTR_HIDDEN. Changed to CMD_ATTR_DEPRECATED.
File src/osmo-bsc/lchan_select.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/28327/comment/d398378f_c27a3a38 PS1, Line 254: chan_alloc_reverse = bts->chan_alloc_chan_req_reverse;
you could put these in an array chan_alloc_mode[] since you already have an enum. […]
I'll keep this as is for now.