Attention is currently required from: pespin.

View Change

2 comments:

• File src/osmo-bsc/bts_vty.c:

  • Patch Set #1, Line 541: DEFUN_ATTR(cfg_bts_challoc_mode_all,

    iiuc this should be marked as DEPRECATED in favor of "mode set-all"

    It was already marked as CMD_ATTR_HIDDEN. Changed to CMD_ATTR_DEPRECATED.

• File src/osmo-bsc/lchan_select.c:

  • Patch Set #1, Line 254: chan_alloc_reverse = bts->chan_alloc_chan_req_reverse;

    you could put these in an array chan_alloc_mode[] since you already have an enum. […]

    I'll keep this as is for now.

To view, visit change 28327. To unsubscribe, or for help writing mail filters, visit settings.