Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29695 )
Change subject: msc_a,vlr: add ciphering_required (accurately named) ......................................................................
Patch Set 1:
(1 comment)
File src/libvlr/vlr_access_req_fsm.c:
https://gerrit.osmocom.org/c/osmo-msc/+/29695/comment/c755ddfa_44b9aee2 PS1, Line 662: par->try_ciphering = try_ciphering;
did you think about adding a check for "(!try_ciphering && ciphering_required)" ? Because if you get […]
it can never happen, see the callers in gsm_04_08.c. But i can add an assert.
in general, we don't assert / guard against everything in non-public API, otherwise we would have e.g. assertions for non-NULL pointers absolutely everywhere. it makes sense to not clutter the code with code paths that can never happen.