Attention is currently required from: pespin.

View Change

1 comment:

• File src/libvlr/vlr_access_req_fsm.c:

  • Patch Set #1, Line 662: par->try_ciphering = try_ciphering;

    did you think about adding a check for "(!try_ciphering && ciphering_required)" ? Because if you get […]

    it can never happen, see the callers in gsm_04_08.c. But i can add an assert.

    in general, we don't assert / guard against everything in non-public API, otherwise we would have e.g. assertions for non-NULL pointers absolutely everywhere.
    it makes sense to not clutter the code with code paths that can never happen.

To view, visit change 29695. To unsubscribe, or for help writing mail filters, visit settings.