Attention is currently required from: pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email )
Change subject: transceiver: split control command handling from socket I/O ......................................................................
Patch Set 4:
(4 comments)
File Transceiver52M/Transceiver.h:
https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/1c5ee6e8_752d670d?usp=... : PS3, Line 220: int ctrl_cmd_handle(int chan, const char *buffer, char *response, size_t response_size);
It's fine if CI fails in this file, we wan overwrite it manually.
Fixed indentation.
File Transceiver52M/Transceiver.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/c601bc4a_e9677bee?usp=... : PS3, Line 831: static bool match_cmd(const char *buf,
This can be done in a previous separate commit.
I've added a separate patch for this - https://gerrit.osmocom.org/c/osmo-trx/+/42420
https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/ee89e3f1_ada61c16?usp=... : PS3, Line 1026: return -EINVAL;
My point is that I don't see why do you decided to move the "return EINVAL here instead of 0 and dec […]
I've added a separate patch for this - https://gerrit.osmocom.org/c/osmo-trx/+/42421
https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/34518f1f_307609fb?usp=... : PS3, Line 1091: return rc == -EINVAL ? 0 : rc; /* Ignore invalid values, but report other errors */
The logic is preserved here. […]
I've added a separate patch for this - https://gerrit.osmocom.org/c/osmo-trx/+/42421