Attention is currently required from: pespin.

View Change

4 comments:

• File Transceiver52M/Transceiver.h:

  • Patch Set #3, Line 220: int ctrl_cmd_handle(int chan, const char *buffer, char *response, size_t response_size);

    It's fine if CI fails in this file, we wan overwrite it manually.

    Fixed indentation.

• File Transceiver52M/Transceiver.cpp:

  • Patch Set #3, Line 831: static bool match_cmd(const char *buf,

    This can be done in a previous separate commit.

    I've added a separate patch for this - https://gerrit.osmocom.org/c/osmo-trx/+/42420

  • Patch Set #3, Line 1026: return -EINVAL;

    My point is that I don't see why do you decided to move the "return EINVAL here instead of 0 and dec […]

    I've added a separate patch for this - https://gerrit.osmocom.org/c/osmo-trx/+/42421

  • Patch Set #3, Line 1091: return rc == -EINVAL ? 0 : rc; /* Ignore invalid values, but report other errors */

    The logic is preserved here. […]

    I've added a separate patch for this - https://gerrit.osmocom.org/c/osmo-trx/+/42421

To view, visit change 42410. To unsubscribe, or for help writing mail filters, visit settings.