Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/28176 )
Change subject: coding: add gsm0503_detect_a[fh]s_dtx_frame2()
......................................................................
Patch Set 2:
(1 comment)
File src/coding/gsm0503_amr_dtx.c:
https://gerrit.osmocom.org/c/libosmocore/+/28176/comment/41180d83_05cc3dd9
PS2, Line 109: if (*sbits == 0 || id_marker[k] != S2U(*sbits))
I see everywhere you use S2U you also check agianst
*sbits==0. […]
No, it does not because 0 is a special value indicating uncertainty
between 1 and 0. If we go for '<=', then soft-bit 0 would be equal to -127 or
hard-bit 1. Other code parts in libosmocoding also treat soft-bit 0 as an error, so I am
doing the same here.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/28176
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibcac395f800bb64150c97fcdaca3523ecfc5fcee
Gerrit-Change-Number: 28176
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 24 May 2022 11:23:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment