Attention is currently required from: pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35421?usp=email )
Change subject: client SDP: more verbose error logging ......................................................................
Patch Set 1:
(2 comments)
File src/libosmo-mgcp-client/mgcp_client.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/35421/comment/5eb76095_3dbdd07e PS1, Line 376: LOGP(DLMGCP, LOGL_ERROR,
So now this log line can be dropped? it makes no sense to print twice imho.
it would be the other one below, with the "_pt:" label...
https://gerrit.osmocom.org/c/osmo-mgw/+/35421/comment/9dcb8c57_78d220c1 PS1, Line 382: "Failed to parse SDP parameter payload types (%s)\n", line); ...this one. I think it's not harmful to also print the SDP string that failed to parse. If you think it's too verbose for LOGL_ERROR, then we can put either the above or this one on DEBUG log...?