Attention is currently required from: pespin.

View Change

2 comments:

• File src/libosmo-mgcp-client/mgcp_client.c:

  • Patch Set #1, Line 376: LOGP(DLMGCP, LOGL_ERROR,

    So now this log line can be dropped? it makes no sense to print twice imho.

    it would be the other one below, with the "_pt:" label...

  • Patch Set #1, Line 382: "Failed to parse SDP parameter payload types (%s)\n", line);

    ...this one.
    I think it's not harmful to also print the SDP string that failed to parse.
    If you think it's too verbose for LOGL_ERROR, then we can put either the above or this one on DEBUG log...?

To view, visit change 35421. To unsubscribe, or for help writing mail filters, visit settings.