Attention is currently required from: pespin, lynxis lazus. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31199 )
Change subject: sgsn: Add TC_attach_timeout_after_pdp_act ......................................................................
Patch Set 2:
(5 comments)
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31199/comment/5d61801b_cf3ca... PS1, Line 1020: private function f_TC_attach_timeout_after_pdp_act(charstring id) runs on BSSGP_ConnHdlr {
Is there an associated OS# ticket? may be worth adding it on top of the function together with quick […]
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31199/comment/a1aba193_fa25a... PS1, Line 1023: const integer ran_index := 0, gmm_attach_repeats := 5;
please in general one variable per line, specially if you are initializing them.
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31199/comment/cc461b86_9c02c... PS1, Line 1024: /* Standard T3350 value */
is tha standard as per spec? which one?
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31199/comment/fcf95e78_34ad6... PS1, Line 1037: attach_req.msgs.gprs_mm.attachRequest.msNetworkCapability.msNetworkCapabilityV.revisionLevelIndicatior := '1'B;
do we really need this lines changing capabilities? I don't think so?
As stated in the comment, if you look at f_gmm_attach(), there are comments concerning these lines. I didn't think it was the right time investment to in-depth read up on the whole attach procedure just to understand what's replicated from a working attach function.
If it's not needed here although the attach function used in the other testcases does it, please tell me why.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31199/comment/c417d6c8_187df... PS1, Line 1044: log("Trying to receive ", gmm_attach_repeats, " ATTACH ACCEPTs");
by repeats here I guess you mean retransmits?
Technically, it's not just the transmission of ATTACH ACCEPT that's repeated by the SGSN, either