Attention is currently required from: pespin, lynxis lazus.

View Change

5 comments:

• File sgsn/SGSN_Tests.ttcn:

  • Patch Set #1, Line 1020: private function f_TC_attach_timeout_after_pdp_act(charstring id) runs on BSSGP_ConnHdlr {

    Is there an associated OS# ticket? may be worth adding it on top of the function together with quick […]

    Done

  • Patch Set #1, Line 1023: const integer ran_index := 0, gmm_attach_repeats := 5;

    please in general one variable per line, specially if you are initializing them.

    Done

  • Patch Set #1, Line 1024: /* Standard T3350 value */

    is tha standard as per spec? which one?

    Done

  • Patch Set #1, Line 1037: attach_req.msgs.gprs_mm.attachRequest.msNetworkCapability.msNetworkCapabilityV.revisionLevelIndicatior := '1'B;

    do we really need this lines changing capabilities? I don't think so?

    As stated in the comment, if you look at f_gmm_attach(), there are comments concerning these lines.
    I didn't think it was the right time investment to in-depth read up on the whole attach procedure just to understand what's replicated from a working attach function.

    If it's not needed here although the attach function used in the other testcases does it, please tell me why.

  • Patch Set #1, Line 1044: log("Trying to receive ", gmm_attach_repeats, " ATTACH ACCEPTs");

    by repeats here I guess you mean retransmits?

    Technically, it's not just the transmission of ATTACH ACCEPT that's repeated by the SGSN, either

To view, visit change 31199. To unsubscribe, or for help writing mail filters, visit settings.