Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27960 )
Change subject: smscb: Store ETWS input state from CBSP ......................................................................
Patch Set 1:
(3 comments)
File src/osmo-bsc/smscb.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27960/comment/13b47158_206381c3 PS1, Line 475: LOG_BTS(bts, DCBS, LOGL_NOTICE, "ETWS PN broadcast voa PCH disabled (cause=%s)\n",
voa?
"via". will fix it.
https://gerrit.osmocom.org/c/osmo-bsc/+/27960/comment/78970c04_d629d71a PS1, Line 510: memcpy(bes->input.sec_info, wrepl->u.emergency.warning_sec_info, ETWS_SEC_INFO_SIZE);
did you check previously you are not going to read out of buffer in wrepl here? by checking msg len […]
the 'wrepl' is something that the CBSP decoder of libosmogsm passes to us, not a raw msbb structure with type cast. Its responsibility is to provide either a NULL pointer as warning_sec_info, or a reasonaybly long memory chunk.
https://gerrit.osmocom.org/c/osmo-bsc/+/27960/comment/3dff8c21_01a26fe7 PS1, Line 705: osmo_timer_del(&bts->etws.timer);
not related to this patch, but you could delete this timer before setting it up in line 542, not sur […]
thanks. this has the "ugly" side-effect of having to export the timer call-back function to the main bts.c code, but I don't have any better ideas either.