Change in osmo-bsc[master]: smscb: Store ETWS input state from CBSP

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27960 ) Change subject: smscb: Store ETWS input state from CBSP ...................................................................... Patch Set 1: (3 comments) File src/osmo-bsc/smscb.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27960/comment/13b47158_206381c3 PS1, Line 475: LOG_BTS(bts, DCBS, LOGL_NOTICE, "ETWS PN broadcast voa PCH disabled (cause=%s)\n", "via". will fix it. https://gerrit.osmocom.org/c/osmo-bsc/+/27960/comment/78970c04_d629d71a PS1, Line 510: memcpy(bes->input.sec_info, wrepl->u.emergency.warning_sec_info, ETWS_SEC_INFO_SIZE); the 'wrepl' is something that the CBSP decoder of libosmogsm passes to us, not a raw msbb structure with type cast. Its responsibility is to provide either a NULL pointer as warning_sec_info, or a reasonaybly long memory chunk. https://gerrit.osmocom.org/c/osmo-bsc/+/27960/comment/3dff8c21_01a26fe7 PS1, Line 705: osmo_timer_del(&bts->etws.timer); thanks. this has the "ugly" side-effect of having to export the timer call-back function to the main bts.c code, but I don't have any better ideas either. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27960 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ide74638880d7e3c6a7c774bf6320d3dce4b11c74 Gerrit-Change-Number: 27960 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Apr 2022 20:02:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment