Attention is currently required from: pespin.

View Change

3 comments:

• File src/osmo-bsc/smscb.c:

  • Patch Set #1, Line 475: LOG_BTS(bts, DCBS, LOGL_NOTICE, "ETWS PN broadcast voa PCH disabled (cause=%s)\n",

    voa?

    "via". will fix it.

  • Patch Set #1, Line 510: memcpy(bes->input.sec_info, wrepl->u.emergency.warning_sec_info, ETWS_SEC_INFO_SIZE);

    did you check previously you are not going to read out of buffer in wrepl here? by checking msg len […]

    the 'wrepl' is something that the CBSP decoder of libosmogsm passes to us, not a raw msbb structure with type cast. Its responsibility is to provide either a NULL pointer as warning_sec_info, or a reasonaybly long memory chunk.

  • Patch Set #1, Line 705: osmo_timer_del(&bts->etws.timer);

    not related to this patch, but you could delete this timer before setting it up in line 542, not sur […]

    thanks. this has the "ugly" side-effect of having to export the timer call-back function to the main bts.c code, but I don't have any better ideas either.

To view, visit change 27960. To unsubscribe, or for help writing mail filters, visit settings.