fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40757?usp=email )
Change subject: Makefile: 'run' becomes an alias of 'shell' ......................................................................
Makefile: 'run' becomes an alias of 'shell'
Running osmo-s1gw in form of an escript executable is prone to errors.
* Move away from escript and make 'run' an alias of 'shell'. * Move `rebar3 escriptize` to a dedicated 'escript' recipe. * Add 'run-escript' recipe in case its ever needed.
Change-Id: I8b34c11cc9361d8b65316401f67a5038544b27ac Related: SYS#7332 --- M Makefile 1 file changed, 5 insertions(+), 1 deletion(-)
Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified
diff --git a/Makefile b/Makefile index ec8a7d6..6b9267d 100644 --- a/Makefile +++ b/Makefile @@ -19,11 +19,15 @@
build: $(GEN_FILES) rebar3 compile + +escript: $(GEN_FILES) rebar3 escriptize
-run: build +run-escript: escript ERL_FLAGS='-config $(CONFIG)' $(REBAR_BASE_DIR)/default/bin/osmo-s1gw
+run: shell + shell: build rebar3 shell --config $(CONFIG)