fixeria submitted this change.

View Change

Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified
Makefile: 'run' becomes an alias of 'shell'

Running osmo-s1gw in form of an escript executable is prone to errors.

* Move away from escript and make 'run' an alias of 'shell'.
* Move `rebar3 escriptize` to a dedicated 'escript' recipe.
* Add 'run-escript' recipe in case its ever needed.

Change-Id: I8b34c11cc9361d8b65316401f67a5038544b27ac
Related: SYS#7332
---
M Makefile
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index ec8a7d6..6b9267d 100644
--- a/Makefile
+++ b/Makefile
@@ -19,11 +19,15 @@

build: $(GEN_FILES)
rebar3 compile
+
+escript: $(GEN_FILES)
rebar3 escriptize

-run: build
+run-escript: escript
ERL_FLAGS='-config $(CONFIG)' $(REBAR_BASE_DIR)/default/bin/osmo-s1gw

+run: shell
+
shell: build
rebar3 shell --config $(CONFIG)


To view, visit change 40757. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I8b34c11cc9361d8b65316401f67a5038544b27ac
Gerrit-Change-Number: 40757
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>