Attention is currently required from: falconia, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32183 )
Change subject: codec: add SID classification functions per GSM 06.31 & 06.81 ......................................................................
Patch Set 1:
(1 comment)
File include/osmocom/codec/codec.h:
https://gerrit.osmocom.org/c/libosmocore/+/32183/comment/3f867d8f_ab0f6f20 PS1, Line 85: etsi_sid_class
Here I used etsi_ and ETSI_ naming prefixes for the enum and its items, as opposed to osmo_ and OSMO […]
@falconia that's not really the rationale behind name prefixes. The osmo_* prefix is used to denote a namespace (C doesn't support namespaces explicitly) in order to avoid collision with other libraries. Imagine your program wants to use another library/header which also defines/implements something from etsi, and it also names it etsi_*, you may end up with type collisions. Hence, all public symbols/defines should start with osmo_*