Attention is currently required from: falconia, fixeria.

View Change

1 comment:

• File include/osmocom/codec/codec.h:

  • Patch Set #1, Line 85: etsi_sid_class

    Here I used etsi_ and ETSI_ naming prefixes for the enum and its items, as opposed to osmo_ and OSMO […]

    @falconia that's not really the rationale behind name prefixes. The osmo_* prefix is used to denote a namespace (C doesn't support namespaces explicitly) in order to avoid collision with other libraries. Imagine your program wants to use another library/header which also defines/implements something from etsi, and it also names it etsi_*, you may end up with type collisions.
    Hence, all public symbols/defines should start with osmo_*

To view, visit change 32183. To unsubscribe, or for help writing mail filters, visit settings.