Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31062 )
Change subject: Introduce netdev API ......................................................................
Patch Set 5: Code-Review+1
(5 comments)
File src/core/netdev.c:
https://gerrit.osmocom.org/c/libosmocore/+/31062/comment/cac2b54d_7670a1eb PS5, Line 61: ) missing : for consistency with other comments
https://gerrit.osmocom.org/c/libosmocore/+/31062/comment/d8dd81ba_2a82705c PS5, Line 199: /* find the netdev for the netdev (if any) */ I find this line more confusing than helpful. Maybe remove it? The function name already explains what it does: netdev_netns_ctx_find_by_netns_name
https://gerrit.osmocom.org/c/libosmocore/+/31062/comment/78dcae57_a6d6f31d PS5, Line 247: recounted refcounted
https://gerrit.osmocom.org/c/libosmocore/+/31062/comment/a7c66770_3a5fa9b8 PS5, Line 394: } Looks like error handling for the !ifname case is missing here
https://gerrit.osmocom.org/c/libosmocore/+/31062/comment/ab01391f_2c5189bd PS5, Line 437: osmo_nedev osmo_netdev