Attention is currently required from: pespin.

Patch set 5:Code-Review +1

View Change

5 comments:

• File src/core/netdev.c:

  • Patch Set #5, Line 61: )

    missing : for consistency with other comments

  • Patch Set #5, Line 199: /* find the netdev for the netdev (if any) */

    I find this line more confusing than helpful. Maybe remove it?
    The function name already explains what it does: netdev_netns_ctx_find_by_netns_name

  • Patch Set #5, Line 247: recounted

    refcounted

  • Patch Set #5, Line 394: }

    Looks like error handling for the !ifname case is missing here

  • Patch Set #5, Line 437: osmo_nedev

    osmo_netdev

To view, visit change 31062. To unsubscribe, or for help writing mail filters, visit settings.