Attention is currently required from: pespin, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31144 )
Change subject: pcu_sock: transfer E1 connection information to PCU ......................................................................
Patch Set 4:
(4 comments)
File src/osmo-bsc/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31144/comment/d6712dac_f7f8dd9f PS1, Line 315: struct gsm_bts_trx_ts *ts;
This is actually a good practice. […]
Thanks. I prefer to have everything at the top so I can immediately see what variables are present. I didn't know that the K&R (the book I learned C with) manual had a more relaxed view about this.
https://gerrit.osmocom.org/c/osmo-bsc/+/31144/comment/a392f8d2_c080c736 PS1, Line 368: /* In cases where the CCU is connected via an E1 line, we
Would be less invasive if you ncrease the comment line width and end up with less lines imho.
Done
File src/osmo-bsc/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31144/comment/1ee21dd6_6709b1d0 PS3, Line 318: if (!trx)
this condition can never be true
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/31144/comment/d04224ed_45e09075 PS3, Line 346: LOGP
Let's use LOG_TRX here. This will shorten the logging message to: […]
Done