Attention is currently required from: pespin, fixeria.
4 comments:
File src/osmo-bsc/pcu_sock.c:
Patch Set #1, Line 315: struct gsm_bts_trx_ts *ts;
This is actually a good practice. […]
Thanks. I prefer to have everything at the top so I can immediately see what variables are present. I didn't know that the K&R (the book I learned C with) manual had a more relaxed view about this.
Patch Set #1, Line 368: /* In cases where the CCU is connected via an E1 line, we
Would be less invasive if you ncrease the comment line width and end up with less lines imho.
Done
File src/osmo-bsc/pcu_sock.c:
Patch Set #3, Line 318: if (!trx)
this condition can never be true
Done
Let's use LOG_TRX here. This will shorten the logging message to: […]
Done
To view, visit change 31144. To unsubscribe, or for help writing mail filters, visit settings.