[M] Change in osmo-bsc[master]: abis_nm: handle NM_EV_SW_ACT_REP in ST_OP_DISABLED_{DEPENDENCY,OFFLINE}

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34470?usp=email ) Change subject: abis_nm: handle NM_EV_SW_ACT_REP in ST_OP_DISABLED_{DEPENDENCY,OFFLINE} ...................................................................... Patch Set 1: (3 comments) File src/osmo-bsc/nm_bts_sm_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34470/comment/e3da0ddb_eebdf5e3 PS1, Line 123: case NM_EV_SW_ACT_REP: Because no other events in this function call it, e.g. `NM_EV_SETUP_RAMP_READY` does not. Do you think it should be called here? And also in the case of `NM_EV_SETUP_RAMP_READY`? I can update the patch. File src/osmo-bsc/nm_gprs_nsvc_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34470/comment/3a85e2d5_7cdee485 PS1, Line 179: case NM_EV_SW_ACT_REP: It's not missing. What's missing is the `break`, so we fall-through. https://gerrit.osmocom.org/c/osmo-bsc/+/34470/comment/4ebea1f4_6b290d7d PS1, Line 233: case NM_EV_SW_ACT_REP: It's not missing. What's missing is the `break`, so we fall-through. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34470?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I00a423adcde5c34977f4c4dad920874687fa493c Gerrit-Change-Number: 34470 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Sep 2023 08:44:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment