25 Aug
2023
25 Aug
'23
3:42 p.m.
Attention is currently required from: arehbein, fixeria, daniel.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198 )
Change subject: stream: Add client-side (segmentation) support for IPA ......................................................................
Patch Set 19: Code-Review+1
(1 comment)
Patchset:
PS19:
I rechecked and all of a sudden, the timestamps aren't deterministic anymore. […]
that's probably because you are not using fake time during the test. But I'm not sure whether logging actually uses fake time. In any case, you should disable logging timestamps in tests. See for instance: """ tests/gsup/gsup_test.c 753: log_set_print_timestamp(osmo_stderr_target, 0); """
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6
Gerrit-Change-Number: 33198
Gerrit-PatchSet: 19
Gerrit-Owner: arehbein arehbein@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: daniel dwillmann@sysmocom.de
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: arehbein arehbein@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: daniel dwillmann@sysmocom.de
Gerrit-Comment-Date: Fri, 25 Aug 2023 15:42:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: arehbein arehbein@sysmocom.de
Comment-In-Reply-To: daniel dwillmann@sysmocom.de
Gerrit-MessageType: comment