Attention is currently required from: arehbein, fixeria, daniel.

Patch set 19:Code-Review +1

View Change

1 comment:

• Patchset:

  • Patch Set #19:

    I rechecked and all of a sudden, the timestamps aren't deterministic anymore. […]

    that's probably because you are not using fake time during the test. But I'm not sure whether logging actually uses fake time. In any case, you should disable logging timestamps in tests. See for instance:
    """
    tests/gsup/gsup_test.c
    753: log_set_print_timestamp(osmo_stderr_target, 0);
    """

To view, visit change 33198. To unsubscribe, or for help writing mail filters, visit settings.