Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31155 )
Change subject: common: Fix memleak in get_smscb_block() ......................................................................
Patch Set 5:
(2 comments)
File src/common/cbch.c:
https://gerrit.osmocom.org/c/osmo-bts/+/31155/comment/d1d7caa4_9d3b9f6b PS5, Line 142: block_type->lb = block_nr + 1 == msg->num_segs; Lots of missing parenthesis here, I first thought you were doing double assignment.
https://gerrit.osmocom.org/c/osmo-bts/+/31155/comment/a0895e34_727e0eb7 PS5, Line 150: } else you must keep {} in "else" if the "if" block has {} (coding style).