Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31155 ) Change subject: common: Fix memleak in get_smscb_block() ...................................................................... Patch Set 5: (2 comments) File src/common/cbch.c: https://gerrit.osmocom.org/c/osmo-bts/+/31155/comment/d1d7caa4_9d3b9f6b PS5, Line 142: block_type->lb = block_nr + 1 == msg->num_segs; Lots of missing parenthesis here, I first thought you were doing double assignment. https://gerrit.osmocom.org/c/osmo-bts/+/31155/comment/a0895e34_727e0eb7 PS5, Line 150: } else you must keep {} in "else" if the "if" block has {} (coding style). -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31155 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3dc116d6c16c80b31712b2a969f0b2a6998b03f0 Gerrit-Change-Number: 31155 Gerrit-PatchSet: 5 Gerrit-Owner: arehbein <arehbein@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: arehbein <arehbein@sysmocom.de> Gerrit-Comment-Date: Thu, 02 Feb 2023 11:17:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment