Attention is currently required from: iedemam. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 )
Change subject: stats: new trackers for lchan life duration ......................................................................
Patch Set 19:
(4 comments)
Patchset:
PS19: looks good, a minor tweak remains for me, in the comments.
File src/osmo-bsc/bts_trx_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/83774c65_a30ea133 PS19, Line 576: VTY_NEWLINE); this will print nonsense values for lchan types other than SDCCH and TCH, unless we remove those conditions marked elsewhere
File src/osmo-bsc/lchan_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/4aee7e57_da3225d4 PS19, Line 225: if (lchan->active_cc.cfg.rate_ctr) { let's remove this condition: always (re)start the activity time_cc, also for lchan types other than SDCCH and TCH. Hence the VTY can also show for those how long ago they have been activated. Doesn't matter whether a rate_ctr is set.
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/de467308_40a97016 PS19, Line 560: if (lchan->active_cc.cfg.rate_ctr) { remove this condition, always set the flag. Does not matter wheter a rate_ctr is set.