Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39395?usp=email )
Change subject: ipa: Split msgb generation into its own helper function ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/ipa.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/39395/comment/9ee2d7ad_9aa659... : PS1, Line 102: OSMO_ASSERT(as->cfg.proto == OSMO_SS7_ASP_PROT_IPA);
I initally did as you say but I later changed it since it was the other way in already existing sua/ […]
Well, maybe the existing `sua/m3ua_tx_xua_as()` should be updated then? It's not super critical and I am not blocking. But it looks weird that the code is first assuming and doing something, and then asserting.