Attention is currently required from: osmith, pespin.
Patch set 1:Code-Review +1
View Change
1 comment:
File src/ipa.c:
Patch Set #1, Line 102: OSMO_ASSERT(as->cfg.proto == OSMO_SS7_ASP_PROT_IPA);
I initally did as you say but I later changed it since it was the other way in already existing sua/ […]
Well, maybe the existing `sua/m3ua_tx_xua_as()` should be updated then? It's not super critical and I am not blocking. But it looks weird that the code is first assuming and doing something, and then asserting.
To view, visit change 39395. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ic0a405ab4d1811efea137167dcb08c9308a4d7e7
Gerrit-Change-Number: 39395
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Attention: osmith <osmith@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Wed, 22 Jan 2025 12:42:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>