Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/29996 )
Change subject: Improve MS logging
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-pcu/+/29996/comment/1a1f6e1d_7838fc0d
PS1, Line 9: towaht
to what
Done
File src/gprs_ms.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/29996/comment/4736e27b_4cc6847f
PS1, Line 1030: if (tlli != GSM_RESERVED_TMSI)
meaning: the indentation is wrong, should be two tabs,
not three in the line below.
Done
https://gerrit.osmocom.org/c/osmo-pcu/+/29996/comment/be3058fb_76002e5c
PS1, Line 1040: return buf;
dead code, did you mean to delete everything below
this return?
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/29996
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: If9b325764c8fd540d60b6419f32223fd7f5a5898
Gerrit-Change-Number: 29996
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 04 Nov 2022 04:00:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment