Attention is currently required from: osmith, pespin.
View Change
3 comments:
Commit Message:
File src/gprs_ms.c:
Patch Set #1, Line 1030: if (tlli != GSM_RESERVED_TMSI)
meaning: the indentation is wrong, should be two tabs, not three in the line below.
Done
Patch Set #1, Line 1040: return buf;
dead code, did you mean to delete everything below this return?
Done
To view, visit change 29996. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: If9b325764c8fd540d60b6419f32223fd7f5a5898
Gerrit-Change-Number: 29996
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-CC: osmith <osmith@sysmocom.de>
Gerrit-Attention: osmith <osmith@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Fri, 04 Nov 2022 04:00:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith@sysmocom.de>
Gerrit-MessageType: comment