Attention is currently required from: pespin.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34144 )
Change subject: osmo_io: Avoid potential double free when sending msgb ......................................................................
Patch Set 2:
(1 comment)
File src/core/osmo_io.c:
https://gerrit.osmocom.org/c/libosmocore/+/34144/comment/16aac7e4_4bd68661 PS2, Line 106: talloc_steal(iofd, msg);
I wonder whether this is really needed. […]
Here iofd_msghdr_alloc is called with a msg - this happens in the send path when a user calls osmo_iofd_{sendto,write}_msgb()
The user could have any parent as msgb, that's why we need to talloc_steal() it here.
Otherwise I could call talloc_steal() in each of the send functions individually.