Attention is currently required from: pespin.

View Change

1 comment:

• File src/core/osmo_io.c:

  • Patch Set #2, Line 106: talloc_steal(iofd, msg);

    I wonder whether this is really needed. […]

    Here iofd_msghdr_alloc is called with a msg - this happens in the send path when a user calls osmo_iofd_{sendto,write}_msgb()

    The user could have any parent as msgb, that's why we need to talloc_steal() it here.

    Otherwise I could call talloc_steal() in each of the send functions individually.

To view, visit change 34144. To unsubscribe, or for help writing mail filters, visit settings.