Attention is currently required from: neels, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/36347?usp=email )
Change subject: pfcp up_function_features: allow shorter lengths ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/libosmo-pfcp/pfcp_ies_custom.c:
https://gerrit.osmocom.org/c/libosmo-pfcp/+/36347/comment/07fe9b28_7f2fce94 PS1, Line 435: * if the peer sends less octets, make do with what we get. */
"make do" ?
https://dictionary.cambridge.org/dictionary/english/make-do
https://gerrit.osmocom.org/c/libosmo-pfcp/+/36347/comment/8f2d8350_a4151eef PS1, Line 436: memset(up_function_features->bits, 0, sizeof(up_function_features->bits));
we can probably avoid memcpying twice.
where's the second memcpy? you mean avoiding memset and memcpy'ing the same location? I'm always hoping compilers are smart enough to figure that out during optimization. But I never really tested that "hope".
Also, this isn't really a super performance critical code path, so let's not over-optimize.