Attention is currently required from: neels, pespin.

Patch set 1:Code-Review +1

View Change

2 comments:

• File src/libosmo-pfcp/pfcp_ies_custom.c:

  • Patch Set #1, Line 435: * if the peer sends less octets, make do with what we get. */

    "make do" ?

    https://dictionary.cambridge.org/dictionary/english/make-do

  • Patch Set #1, Line 436: memset(up_function_features->bits, 0, sizeof(up_function_features->bits));

    we can probably avoid memcpying twice.

    where's the second memcpy? you mean avoiding memset and memcpy'ing the same location? I'm always hoping compilers are smart enough to figure that out during optimization. But I never really tested that "hope".

    Also, this isn't really a super performance critical code path, so let's not over-optimize.

To view, visit change 36347. To unsubscribe, or for help writing mail filters, visit settings.