Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41132?usp=email )
Change subject: RAN_{Emulation,Adapter}: Split transport type from transport client/server mode ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File library/RAN_Adapter.ttcnpp:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41132/comment/01c64eff_b208c... : PS2, Line 120: ba.vc_IPA := IPA_Emulation_CT.create(id & "-IPA") alive; : map(ba.vc_IPA:IPA_PORT, system:IPA_CODEC_PT); : /* connect MTP3 service provider (IPA) to lower side of SCCP */ : connect(ba.vc_IPA:MTP3_SP_PORT, ba.vc_SCCP:MTP3_SCCP_PORT); : /* connect waiter to general IPA port (for ASP_IPA_Event) */ : ba.vc_WAIT := IPA_EventWaiter_CT.create(id & "-IPA-WAIT") alive; : connect(ba.vc_IPA:IPA_SP_PORT, ba.vc_WAIT:IPA_SP_PORT); : Unneeded indent level? (shift left)
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41132/comment/3a61872c_b1c84... : PS2, Line 138: /* wait until we received an IPA CCM ID_ACK */ : ba.vc_WAIT.done; : Likewise here, why are you adding an indent level?